Skip to content

Add GithubPlugin 1.1.1-alpha to Plugins.json #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

parkour86
Copy link
Contributor

Checks

@Core447
Copy link
Member

Core447 commented Jul 6, 2025

Amazing work!

Any particular reason you're writing the changes manually to ~/.config/streamcontroller/github_plugin_settings.json" instead of set_settings and get_settings from the PluginBase?

@parkour86
Copy link
Contributor Author

Amazing work!

Any particular reason you're writing the changes manually to ~/.config/streamcontroller/github_plugin_settings.json" instead of set_settings and get_settings from the PluginBase?

The set_settings and get_settings functions currently update settings on a per-button basis. Since users will have 6–7 buttons, I’d like to avoid requiring them to enter their API credentials multiple times.

Is there a better way to share or synchronize the settings across multiple buttons?

@Core447
Copy link
Member

Core447 commented Jul 6, 2025

Is there a better way to share or synchronize the settings across multiple buttons?

You can use the methods of the plugin manager. For an example you can checkout: https://github.com/StreamController/OBSPlugin/blob/bd2cfc343ed55f53612d9ccc83f0a8fbe91e779a/OBSActionBase.py#L58-L61

@parkour86
Copy link
Contributor Author

Thanks, i'll try this method and push the change since my method is insecure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants